You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 09:51:28 UTC

[GitHub] [superset] junlincc commented on pull request #12489: fix: make pyparsing thread safe

junlincc commented on pull request #12489:
URL: https://github.com/apache/superset/pull/12489#issuecomment-759335627


   lgtm!
   
   **Without lock** 
   <img width="1767" alt="Screen Shot 2021-01-13 at 1 49 47 AM" src="https://user-images.githubusercontent.com/67837651/104435875-c0c05f00-5541-11eb-8c30-c266f6f6169e.png">
   **With lock**
   <img width="1785" alt="Screen Shot 2021-01-13 at 1 50 14 AM" src="https://user-images.githubusercontent.com/67837651/104435891-c6b64000-5541-11eb-975c-14ff0d65eaf2.png">
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org