You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/09 13:49:43 UTC

[GitHub] [shardingsphere] menghaoranss opened a new issue #11735: The parameter executionGroupContext not used in ExecuteProcessStrategyEvaluator.evaluate

menghaoranss opened a new issue #11735:
URL: https://github.com/apache/shardingsphere/issues/11735


   ## Question
   
   ```
   /**
        * Evaluate.
        *
        * @param context context
        * @param executionGroupContext execution group context
        * @param props configuration properties
        * @return submit or not
        */
       public static boolean evaluate(final SQLStatementContext<?> context, final ExecutionGroupContext<? extends SQLExecutionUnit> executionGroupContext, final ConfigurationProperties props) {
           boolean showProcessListEnabled = props.getValue(ConfigurationPropertyKey.SHOW_PROCESS_LIST_ENABLED);
           SQLStatement statement = context.getSqlStatement();
           boolean statementEnabled = statement instanceof DDLStatement || statement instanceof DMLStatement;
           return showProcessListEnabled && statementEnabled;
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #11735: The parameter executionGroupContext not used in ExecuteProcessStrategyEvaluator.evaluate

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #11735:
URL: https://github.com/apache/shardingsphere/issues/11735#issuecomment-1046498313


   `executionGroupContext` is not used in `ExecuteProcessStrategyEvaluator` for now, since `show processlist` feature is not used widely and not compelted totally, so we could keep `executionGroupContext` for now, it might be needed later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed issue #11735: The parameter executionGroupContext not used in ExecuteProcessStrategyEvaluator.evaluate

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #11735:
URL: https://github.com/apache/shardingsphere/issues/11735


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org