You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/10/28 18:48:20 UTC
Review Request 27293: SQOOP-1444 Sqoop2: Validations: Remove all
references to the original Validation infastructure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27293/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1444
https://issues.apache.org/jira/browse/SQOOP-1444
Repository: sqoop-sqoop2
Description
-------
I've removed all references to the old validator infrastructure.
Diffs
-----
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 9e78fe9
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java 682f63b
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 923a943
common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java fc5b21d
common/src/test/java/org/apache/sqoop/validation/TestValidation.java 16a8bbe
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 3a6621a
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 93989a4
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 1640f80
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java b995efd
core/src/main/java/org/apache/sqoop/driver/Driver.java ce0b471
core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java d9eb182
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 6ca6c18
spi/src/main/java/org/apache/sqoop/validation/Validator.java 2909905
Diff: https://reviews.apache.org/r/27293/diff/
Testing
-------
Tests are passing.
Thanks,
Jarek Cecho
Re: Review Request 27293: SQOOP-1444 Sqoop2: Validations: Remove all
references to the original Validation infastructure
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27293/#review58847
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Oct. 28, 2014, 5:48 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27293/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 5:48 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1444
> https://issues.apache.org/jira/browse/SQOOP-1444
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've removed all references to the old validator infrastructure.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 9e78fe9
> common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java 682f63b
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 923a943
> common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e
> common/src/test/java/org/apache/sqoop/json/TestValidationBean.java fc5b21d
> common/src/test/java/org/apache/sqoop/validation/TestValidation.java 16a8bbe
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 3a6621a
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java 93989a4
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 1640f80
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsValidator.java b995efd
> core/src/main/java/org/apache/sqoop/driver/Driver.java ce0b471
> core/src/main/java/org/apache/sqoop/driver/DriverConfigValidator.java d9eb182
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 6ca6c18
> spi/src/main/java/org/apache/sqoop/validation/Validator.java 2909905
>
> Diff: https://reviews.apache.org/r/27293/diff/
>
>
> Testing
> -------
>
> Tests are passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>