You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/18 12:10:00 UTC
[jira] [Commented] (CB-14098) Remove unused res folder from app
template
[ https://issues.apache.org/jira/browse/CB-14098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480566#comment-16480566 ]
ASF GitHub Bot commented on CB-14098:
-------------------------------------
raphinesse opened a new pull request #21: CB-14098: Remove unused res folder
URL: https://github.com/apache/cordova-app-hello-world/pull/21
### Platforms affected
All
### What does this PR do?
Remove unused icons and splash screens from this template to save 10MiB in every cordova project created from it and every installation of `cordova`.
### What testing has been done on this change?
Manual. I can create a new project with this, `add platform android` and `run` it. Has no obviously missing assets.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove unused res folder from app template
> ------------------------------------------
>
> Key: CB-14098
> URL: https://issues.apache.org/jira/browse/CB-14098
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-app-hello-world
> Affects Versions: 3.11.0
> Reporter: Raphael
> Priority: Major
>
> The res folder weighs around 10MiB and contains resources for a whole lot of platforms, most of which are actually deprecated. Furthermore, as I understand the included `README.md` (which I'm not sure I do), the contents of this folder seem to not even being used for anything.
> So my proposal is to remove this directory from the template. That would decrease the installation size of `cordova` by about two thirds and remove unnecessary clutter from any newly created apps.
> If I did get anything wrong and this is actually used, we should probably clarify the README, remove all content related to deprecated platforms (like suggested in CB-13726) and run them through some compressors (pngquant and zopflipng).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org