You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2015/02/04 23:16:04 UTC

svn commit: r1657427 - in /jmeter/trunk: src/components/org/apache/jmeter/visualizers/backend/BackendListener.java src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java xdocs/changes.xml

Author: pmouawad
Date: Wed Feb  4 22:16:03 2015
New Revision: 1657427

URL: http://svn.apache.org/r1657427
Log:
Bug 57537 - BackendListener : Allow implementations to drop samples
Bugzilla Id: 57537

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java?rev=1657427&r1=1657426&r2=1657427&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java Wed Feb  4 22:16:03 2015
@@ -169,6 +169,12 @@ public class BackendListener extends Abs
         BackendListenerContext context = new BackendListenerContext(args);
 
         SampleResult sr = listenerClientData.client.createSampleResult(context, event.getResult());
+        if(sr == null) {
+            if(LOGGER.isDebugEnabled()) {
+                LOGGER.debug(getName()+"=>Dropping SampleResult:"+event.getResult());
+            }
+            return;
+        }
         try {
             if (!listenerClientData.queue.offer(sr)){ // we failed to add the element first time
                 listenerClientData.queueWaits.incrementAndGet();

Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java?rev=1657427&r1=1657426&r2=1657427&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListenerClient.java Wed Feb  4 22:16:03 2015
@@ -117,7 +117,8 @@ public interface BackendListenerClient {
     /**
      * Create a copy of SampleResult, this method is here to allow customizing 
      * what is kept in the copy, for example copy could remove some useless fields.
-     * Default to cloning
+     * Note that if your return null, sampler is not put in queue.
+     * Defaults to cloning
      * @param context {@link BackendListenerContext}
      * @param result {@link SampleResult}
      * @return {@link SampleResult}

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1657427&r1=1657426&r2=1657427&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Wed Feb  4 22:16:03 2015
@@ -206,6 +206,7 @@ See  <bugzilla>56357</bugzilla> for deta
 <li><bug>55932</bug>Create a Async BackendListener to allow easy plug of new listener (Graphite, JDBC, Console,...)</li>
 <li><bug>57246</bug>BackendListener : Create a Graphite implementation</li>
 <li><bug>57217</bug>Aggregate graph and Aggregate report improvements (3 configurable percentiles, same data in both, factor out code). Contributed by Ubik Load Pack (support at ubikloadpack.com)</li>
+<li><bug>57537</bug>BackendListener : Allow implementations to drop samples</li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>