You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Rich Feit (JIRA)" <be...@incubator.apache.org> on 2004/11/11 02:37:23 UTC
[jira] Created: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Page Flow Overview - simple actions versus complex actions
----------------------------------------------------------
Key: BEEHIVE-80
URL: http://nagoya.apache.org/jira/browse/BEEHIVE-80
Project: Beehive
Type: Improvement
Components: Documentation
Versions: V1Alpha
Reporter: Rich Feit
Assigned to: Steve Hanson
Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
@Jpf.Action(
forwards = {
@Jpf.Forward( name="success", path="signup.jsp" );
}
)
public Forward signUp()
{
return new Forward( "success" );
}
@Jpf.Action(
forwards = {
@Jpf.Forward( name="success", path="login.jsp" );
}
)
public Forward login()
{
return new Forward( "success" );
}
...with this, at the class level:
@Jpf.Controller(
simpleActions={
@Jpf.SimpleAction(name="signUp", path="signup.jsp"),
@Jpf.SimpleAction(name="login", path="login.jsp")
}
)
It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Nathan Jantz (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-80?page=all ]
Nathan Jantz closed BEEHIVE-80:
-------------------------------
Assign To: Nathan Jantz (was: Rich Feit)
Verified in 1.0m1-rc2.
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://issues.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Nathan Jantz
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Reopened: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-80?page=history ]
Rich Feit reopened BEEHIVE-80:
------------------------------
Assign To: Steve Hanson
I really think that the simple actions in the example should actually be done as SimpleActions. I think that it's a good first place to start, rather than with method actions that could be replaced with SimpleActions. What do you think?
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Steve Hanson
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Reopened: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-80?page=history ]
Rich Feit reopened BEEHIVE-80:
------------------------------
Hmm... I don't agree, but it's your call. However, I do agree with Jeremiah that it's too confusing with an offhand paragraph about Simple Actions, and that this should be moved to a separate area of the doc.
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://issues.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Rich Feit
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Steve Hanson (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-80?page=history ]
Steve Hanson resolved BEEHIVE-80:
---------------------------------
Assign To: Rich Feit (was: Steve Hanson)
Resolution: Won't Fix
I agree with Jeremy on this one. If you look at the entire doc series provided by Codehause Bob (Overview-->Controllers-->JSP, and so on) it is based on the most basic JAVA and JSP knowledge. Basically the assumptions are: (1) You know what a Java method is and (2) you know what a JSP page is. But Codehause Bob doesn't assume you know anything like (3) these two things can be connected! (action methods) or (4) there are metadata annotations that configure your app. This one of the strengths of the doc, even if involves some non-ideal code (like making navigational actions into stand-alone Java methods, instead of Simple Actions).
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://issues.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Rich Feit
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Jeremiah Johnson (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-80?page=comments#action_56478 ]
Jeremiah Johnson commented on BEEHIVE-80:
-----------------------------------------
I think that the way the page is now is too confusing. The paragraph that was added saying that the method actions can be replaced doesn't give enough detail to be helpful, in my opinion. I would rather see the paragraph pulled out and a new section added to the documents about simple actions.
Rich suggested that maybe it would be better to start with simple actions rather than method actions. Without knowing details about simple actions, I think that the method actions are simple for people to grasp and best to use in the overview documentation.
- jeremiah
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Steve Hanson
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-80?page=history ]
Rich Feit reassigned BEEHIVE-80:
--------------------------------
Assign To: Steve Hanson (was: Rich Feit)
Hey Steve, we emailed about this a few days ago... whatever you think you can do on this...
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://issues.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Steve Hanson
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-80?page=comments#action_56481 ]
Rich Feit commented on BEEHIVE-80:
----------------------------------
Method actions are definitely simple in concept, but in general you wouldn't need to use them just for forwarding to pages. You can replace this (method action):
@Jpf.Action(
forwards={
@Jpf.Forward(name="index", path="index.jsp")
}
)
public Forward someAction()
{
return new Forward( "index" );
}
with this (simple action):
@Jpf.SimpleAction(name="someAction", path="index.jsp")
Given that we do have this feature, it seems strange not to start with it in the cases where it would normally be used.
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Steve Hanson
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Steve Hanson (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-80?page=history ]
Steve Hanson resolved BEEHIVE-80:
---------------------------------
Assign To: Rich Feit (was: Steve Hanson)
Resolution: Fixed
The 'Overview' and 'Controller' topics have been completely redone, now oriented toward action, rather than methods.
See:
http://incubator.apache.org/beehive/v1beta/pageflow/pageflow_overview.html
http://incubator.apache.org/beehive/v1beta/pageflow/pageflow_controllers.html
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://issues.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Assignee: Rich Feit
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-80) Page Flow Overview - simple actions versus complex actions
Posted by "Steve Hanson (JIRA)" <be...@incubator.apache.org>.
[ http://nagoya.apache.org/jira/browse/BEEHIVE-80?page=history ]
Steve Hanson resolved BEEHIVE-80:
---------------------------------
Assign To: (was: Steve Hanson)
Resolution: Fixed
Fix Version: V1Alpha
I added the following paragraph to the doc:
"
The code above can be made even cleaner by defining "simple actions" at the class-level. Using the @Jpf.SimpleAction annotation at the class-level you can remove the controller methods and their annotations altogether. The code above can be replaced with the class-level annotations shown below:
@Jpf.Controller(
simpleActions={
@Jpf.SimpleAction(name="signUp", path="signup.jsp"),
@Jpf.SimpleAction(name="login", path="login.jsp")
}
)
public class Controller
extends PageFlowController
{
}
"
> Page Flow Overview - simple actions versus complex actions
> ----------------------------------------------------------
>
> Key: BEEHIVE-80
> URL: http://nagoya.apache.org/jira/browse/BEEHIVE-80
> Project: Beehive
> Type: Improvement
> Components: Documentation
> Versions: V1Alpha
> Reporter: Rich Feit
> Fix For: V1Alpha
>
> Using "simple actions" could reduce the size of the page flow being discussed, and it might make a clearer case for the method-based actions that come in the section entitled Conditional Forwards. Basically, you could replace code like this:
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="signup.jsp" );
> }
> )
> public Forward signUp()
> {
> return new Forward( "success" );
> }
> @Jpf.Action(
> forwards = {
> @Jpf.Forward( name="success", path="login.jsp" );
> }
> )
> public Forward login()
> {
> return new Forward( "success" );
> }
> ...with this, at the class level:
> @Jpf.Controller(
> simpleActions={
> @Jpf.SimpleAction(name="signUp", path="signup.jsp"),
> @Jpf.SimpleAction(name="login", path="login.jsp")
> }
> )
> It's just a nice (new) feature that can reduce the size/complexity of a page flow class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira