You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/21 03:44:38 UTC

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles

yanghua commented on a change in pull request #1263: [MINOR] Update the javadoc of HoodieTableMetaClient#scanFiles
URL: https://github.com/apache/incubator-hudi/pull/1263#discussion_r368799864
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
 ##########
 @@ -381,7 +381,15 @@ public static HoodieTableMetaClient initTableAndGetMetaClient(Configuration hado
     return metaClient;
   }
 
-  // HELPER METHODS TO CREATE META FILE NAMES
+  /**
+   * Helper methods to create meta file names.
 
 Review comment:
   `methods` -> `method`. IMO, the original comment is incorrect. You should correct the java doc based on the logic of this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services