You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/25 13:40:38 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4117: [pulsar-clients]Store key part of a KeyValue schema into pulsar message keys

sijie commented on a change in pull request #4117: [pulsar-clients]Store key part of a KeyValue schema into pulsar message keys
URL: https://github.com/apache/pulsar/pull/4117#discussion_r278547764
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java
 ##########
 @@ -37,6 +37,14 @@
  * [Key, Value] pair schema definition
  */
 public class KeyValueSchema<K, V> implements Schema<KeyValue<K, V>> {
+
+    public enum KeyValueEncodingType {
+        // key is stored as message key, while value is stored as message payload
+         SEPARATED,
 
 Review comment:
   nit: wrong indent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services