You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2022/09/04 06:34:32 UTC
[GitHub] [isis] andi-huber opened a new pull request, #1080: ISIS-3202: Wicket Viewer Executor not persisting on JPA
andi-huber opened a new pull request, #1080:
URL: https://github.com/apache/isis/pull/1080
This is round 2. We fixed JDO in round 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a diff in pull request #1080: ISIS-3202: Wicket Viewer Executor not persisting on JPA
Posted by GitBox <gi...@apache.org>.
andi-huber commented on code in PR #1080:
URL: https://github.com/apache/isis/pull/1080#discussion_r962283168
##########
core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/actions/action/invocation/ActionInvocationFacetForDomainEventAbstract.java:
##########
@@ -198,7 +199,10 @@ public Object execute(final ActionInvocation currentExecution) {
null);
// the event handlers may have updated the argument themselves
- val argsAfterEventPolling = updateArguments(initialArgs, actionDomainEvent.getArguments());
+ val argsAfterEventPolling = updateArguments(
+ owningAction.getParameters(),
Review Comment:
does this handle the mixin case as previously?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber commented on a diff in pull request #1080: ISIS-3202: Wicket Viewer Executor not persisting on JPA
Posted by GitBox <gi...@apache.org>.
andi-huber commented on code in PR #1080:
URL: https://github.com/apache/isis/pull/1080#discussion_r962270283
##########
examples/demo/wicket/jpa/src/main/java/demoapp/webapp/wicket/jpa/DemoAppWicketJpa.java:
##########
@@ -89,6 +89,7 @@ public static void main(final String[] args) {
//IsisPresets.logging(ComponentFactoryRegistryDefault.class, "debug");
//IsisPresets.logging(EntityModel.class, "debug");
//IsisPresets.logging(FormExecutorDefault.class, "debug");
+ System.setProperty("spring.jpa.show-sql", "true");
Review Comment:
comment out before merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis] andi-huber merged pull request #1080: ISIS-3202: Wicket Viewer Executor not persisting on JPA
Posted by GitBox <gi...@apache.org>.
andi-huber merged PR #1080:
URL: https://github.com/apache/isis/pull/1080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@isis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org