[GitHub] [beam] ibzib commented on a change in pull request #14876: [BEAM-12074] Define docstrings for all DataFrame operations

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14876:
URL: https://github.com/apache/beam/pull/14876#discussion_r647708954



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -2115,11 +2115,18 @@ def fill_matrix(*args):
               requires_partition_by=partitionings.Singleton(),
               proxy=proxy))
 
+  @frame_base.with_docs_from(pd.DataFrame)
   @frame_base.args_to_kwargs(pd.DataFrame)
   @frame_base.populate_defaults(pd.DataFrame)
   def corrwith(self, other, axis, drop, method):
-    if axis not in (0, 'index'):
-      raise NotImplementedError('corrwith(axis=%r)' % axis)
+    if axis in (1, 'columns'):

Review comment:
       What happens if I pass in 2?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org