You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/07/30 17:14:05 UTC

[kudu-CR] WIP tool to rewrite cfiles

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11078


Change subject: WIP tool to rewrite cfiles
......................................................................

WIP tool to rewrite cfiles

Adds a tool to rewrite cfiles while skipping cblocks that have been
corrupted. This cannot be the final solution, since any positional
indexing on the CFile is ruined due to the skipped cblocks, but it's a
start.

Nullable and key CFiles are not supported.

Example:
$ kudu file rewrite_cfile src_cfile dst_cfile

WIP: in skipping corrupted blocks, we're not doing some accounting of
last_prepared_idx_, leading to a DCHECK failure, though I think this
works as expected for a healthy block.

Change-Id: I55a52b7a237e99d0e66218e02c213d4a9a7781e7
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/fs/block_manager.h
M src/kudu/tools/tool_action_file.cc
7 files changed, 330 insertions(+), 99 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11078/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55a52b7a237e99d0e66218e02c213d4a9a7781e7
Gerrit-Change-Number: 11078
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] WIP tool to rewrite cfiles

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/11078 )

Change subject: WIP tool to rewrite cfiles
......................................................................


Abandoned

not sure quite how useful this will be with automated CFile checksum error handling
-- 
To view, visit http://gerrit.cloudera.org:8080/11078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I55a52b7a237e99d0e66218e02c213d4a9a7781e7
Gerrit-Change-Number: 11078
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot