[GitHub] abaruni commented on a change in pull request #240: Parameterize hardcoded host variable

[gi...@git.apache.org]

abaruni commented on a change in pull request #240: Parameterize hardcoded host variable
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/240#discussion_r142165619
 
 

 ##########
 File path: tests/src/test/scala/packages/weather/WeatherTests.scala
 ##########
 @@ -64,4 +65,23 @@ class WeatherTests
             _.response.result.get.toString should include("observation")
         }
     }
-}
+
+    it should """Use "host" property""" in withAssetCleaner(wskprops) {
+        (wp, assetHelper) =>
+        val name = "forecastTest"
+
+        assetHelper.withCleaner(wsk.pkg, name) {
+                    (pkg, name) =>
+                        pkg.bind("/whisk.system/weather", name,
+                            Map("username" -> username,
+                                "password" -> password,
+                                "host" -> host))
+                }
+                
 
 Review comment:
   build.sh says there's a trailing whitespace here. can you remove?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services