[GitHub] [pulsar] lhotari commented on a change in pull request #8880: [logging] Upgrade Log4j2 version to 2.14.0 and replace legacy log4j dependency

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #8880:
URL: https://github.com/apache/pulsar/pull/8880#discussion_r539486219



##########
File path: distribution/server/pom.xml
##########
@@ -95,8 +95,8 @@
     </dependency>
 
     <dependency>
-      <artifactId>log4j</artifactId>
-      <groupId>log4j</groupId>
+      <groupId>org.apache.logging.log4j</groupId>

Review comment:
       Thanks for the review.
   I'm just trying to understand that how the legacy log4j dependency is used. The [log4j-1.2-api as part of Log4j2](https://logging.apache.org/log4j/2.x/log4j-1.2-api/index.html) provides the legacy log4j API but routes the log events to log4j2. I'd assume that this would be the correct approach if legacy log4j and log4j2 co-exist. 
   However is legacy log4j even needed? I see that legacy log4j is excluded from many dependencies. `mvn dependency:tree` didn't give a direct answer, but I can try to investigate by temporarily removing the exclusions locally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org