You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tfournier314 <gi...@git.apache.org> on 2016/10/20 16:58:41 UTC
[GitHub] flink pull request #2668: Add EvaluateDataSetOperation for LabeledVector. Th...
GitHub user tfournier314 opened a pull request:
https://github.com/apache/flink/pull/2668
Add EvaluateDataSetOperation for LabeledVector. This closes #4865
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tfournier314/flink LabeledDataInEvaluate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2668
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2668: Add EvaluateDataSetOperation for LabeledVector. This clos...
Posted by thvasilo <gi...@git.apache.org>.
Github user thvasilo commented on the issue:
https://github.com/apache/flink/pull/2668
Hello Thomas, thank you for your contribution!
I took a brief look so some initial comments:
This seems to be making changes to `MLUtils` which AFAIK is outside the scope of this issue. I would recommend you isolate changes into different issues and PRs.
I also see a lot of style changes to existing code. The code style we try to follow is [this one](https://github.com/databricks/scala-style-guide), I would recommend you review that and try to follow it.
As a rule of thumb we don't make style changes to existing code, unless the existing code does not conform to the linked style. Even in that case I would recommend opening a different PR with only style changes, as it makes reviewing the core PR (which is the added code here) easier.
So I'd recommend to remove the style changes you've made from this PR as well. If there is existing code that violates the linked style we can open a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2668: Add EvaluateDataSetOperation for LabeledVector. This clos...
Posted by tfournier314 <gi...@git.apache.org>.
Github user tfournier314 commented on the issue:
https://github.com/apache/flink/pull/2668
I'm using IntelliJ and I can't remove scala doc and use java doc instead
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2668: Add EvaluateDataSetOperation for LabeledVector. Th...
Posted by tfournier314 <gi...@git.apache.org>.
Github user tfournier314 closed the pull request at:
https://github.com/apache/flink/pull/2668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---