[GitHub] [skywalking] wu-sheng commented on pull request #7429: Fix issues in ElasticSearch 7.14 and add log cases to ES7.14

[GitBox <gi...@apache.org>]

wu-sheng commented on pull request #7429:
URL: https://github.com/apache/skywalking/pull/7429#issuecomment-895767503


   > > Let's limit the not null in the certain scopes.
   > 
   > The nullability check is added according to whether they are annotated with `org.apache.skywalking.oap.server.core.storage.annotation.Column#matchQuery` that will add a `copy_to` field, which causes the problem. If we skip some of the cases mentioned in the comments, the root cause (`serviceName` being null) is hidden behind the ElasticSearch level message, although `serviceName` is expected to be non null,
   
   The changes on the log side are reasonable, and should be done. But why we bother to check these `should-not-null` fields? If you want to check and expose the cause, check on the `source#prepare` stage rather than here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org