[jira] [Commented] (SOLR-7171) BaseDistributedSearchTestCase.getSolrXml() not used consistently - multiple divergent ways a JettySolrRunner may be inited

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342441#comment-14342441 ] 

Erick Erickson commented on SOLR-7171:
--------------------------------------

What Alan said.

It looks fine to me too. One quick note is that it's not even necessary (in non-cloud mode at least) for anything to be _in_ the core.properties file if all the defaults are acceptable, its mere existence is all that's absolutely required. Then the core name is taken from the directory core.properties is found in, the data dir is expected to be a directory in at the same level as core.properties etc..

On a side note, it'd be nice, sometime, to get all traces of "collection1" out of there, but that's not something for the faint of heart, nor should it be conflated with this issue...

> BaseDistributedSearchTestCase.getSolrXml() not used consistently - multiple divergent ways a JettySolrRunner may be inited
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7171
>                 URL: https://issues.apache.org/jira/browse/SOLR-7171
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: SOLR-7171.patch, SOLR-7171.patch
>
>
> As part of SOLR-6349, i wanted to take advantage of the new features in SOLR-7147 to inspect shard requests in TestDistributedSearch, but even though i added a proper override of getSolrXml...
> {code}
>   @Override
>   protected String getSolrXml() {
>     return "solr-trackingshardhandler.xml"; 
>   }
> {code}
> ...that value was being ignored, and i was never getting an instance of TrackingShardHandlerFactory.
> I poked around a bit and confirmed that getSolrXml() is used by "setupJettySolrHome(File)" but that method is never called by BaseDistributedSearchTestCase - it's only called in framework subclasses like AbstractDistribZkTestBase and AbstractFullDistribZkTestBase.  Instead, for simple subclasses of BaseDistributedSearchTestCase the jetty instances seem to be coming from createServers(int)
> ----
> I don't really understand why there are so many diff ways for a shard instance to be inited, and presumably that should be refactored? .. but a more immediate concern is that subclasses of BaseDistributedSearchTestCase which attempt to override the solr.xml file used can't (unless they are actually a subclass of AbstractDistribZkTestBase of AbstractFullDistribZkTestBase)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org