You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/20 02:50:30 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4839: Fix
documentation on LLC configs
codecov-io commented on issue #4839: Fix documentation on LLC configs
URL: https://github.com/apache/incubator-pinot/pull/4839#issuecomment-555812099
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=h1) Report
> Merging [#4839](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a9f659147ec44636138d14d07dbde74fd5ac337c?src=pr&el=desc) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4839 +/- ##
==========================================
- Coverage 37.09% 36.94% -0.16%
==========================================
Files 1214 1214
Lines 65567 65567
Branches 9536 9536
==========================================
- Hits 24323 24222 -101
- Misses 39034 39155 +121
+ Partials 2210 2190 -20
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../pinot/controller/util/SegmentCompletionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlZ21lbnRDb21wbGV0aW9uVXRpbHMuamF2YQ==) | `0% <0%> (-75%)` | :arrow_down: |
| [...e/pinot/core/io/writer/impl/MmapMemoryManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9NbWFwTWVtb3J5TWFuYWdlci5qYXZh) | `0% <0%> (-72.31%)` | :arrow_down: |
| [...aggregation/groupby/ObjectGroupByResultHolder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L09iamVjdEdyb3VwQnlSZXN1bHRIb2xkZXIuamF2YQ==) | `40.9% <0%> (-31.82%)` | :arrow_down: |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | :arrow_down: |
| [...altime/ServerSegmentCompletionProtocolHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VydmVyL3JlYWx0aW1lL1NlcnZlclNlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2xIYW5kbGVyLmphdmE=) | `35.11% <0%> (-15.27%)` | :arrow_down: |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `53.65% <0%> (-14.64%)` | :arrow_down: |
| [...inot/core/query/pruner/PartitionSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvUGFydGl0aW9uU2VnbWVudFBydW5lci5qYXZh) | `65.38% <0%> (-11.54%)` | :arrow_down: |
| [...tion/groupby/DictionaryBasedGroupKeyGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9ncm91cGJ5L0RpY3Rpb25hcnlCYXNlZEdyb3VwS2V5R2VuZXJhdG9yLmphdmE=) | `32.95% <0%> (-10.89%)` | :arrow_down: |
| [.../predicate/NotEqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvcHJlZGljYXRlL05vdEVxdWFsc1ByZWRpY2F0ZUV2YWx1YXRvckZhY3RvcnkuamF2YQ==) | `50.74% <0%> (-8.96%)` | :arrow_down: |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `83.81% <0%> (-8.68%)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/4839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=footer). Last update [a9f6591...f5268b7](https://codecov.io/gh/apache/incubator-pinot/pull/4839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org