[PR] [ZEPPELIN-6587] Keep simple notebook controls accessible without hover [zeppelin]

["yuminnnnni (via GitHub)" <gi...@apache.org>]

yuminnnnni opened a new pull request, #5537:
URL: https://github.com/apache/zeppelin/pull/5537

   ### What is this PR for?
   A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
   
   
   ### What type of PR is it?
   Bug Fix
   Improvement
   Feature
   Documentation
   Hot Fix
   Refactoring
   *Please leave your type of PR only*
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
   * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update?
   * Is there breaking changes for older versions?
   * Does this needs documentation?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6587] Keep simple notebook controls accessible without hover [zeppelin]

["yuminnnnni (via GitHub)" <gi...@apache.org>]

yuminnnnni commented on PR #5537:
URL: https://github.com/apache/zeppelin/pull/5537#issuecomment-6095438077

   The Playwright (auth) job failed on the previous commit because the new desktop hover spec asserted `(any-hover: hover)` on headless Firefox in CI, which reports no hover-capable pointer. I fixed this in 6e4e379 by skipping that spec when the browser reports no hover support; the CSS change is unchanged.
   
   The workflows for the new commit are awaiting maintainer approval. Could a maintainer approve them so CI can run? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6587] Keep simple notebook controls accessible without hover [zeppelin]

["voidmatcha (via GitHub)" <gi...@apache.org>]

voidmatcha commented on PR #5537:
URL: https://github.com/apache/zeppelin/pull/5537#issuecomment-6096266127

   The touch-only CSS change makes sense. I found one test setup issue: the manually created `browser.newContext()` does not inherit `use.baseURL`. `openTestNotebook()` then calls `page.goto("/#/")`, so the WebKit test cannot reach its assertions. Could you pass the `baseURL` fixture to `newContext()`? I prepared an example commit here: https://github.com/voidmatcha/zeppelin/commit/87bdedf507cbb79f2004010b944c190764d46cbc. It also reuses the existing Action Bar page object for the look-and-feel selector.
   
   The current E2E jobs stop at an unrelated Prettier check in `host-remote-contract.ts`. #5564 has now merged into `master`, so rebasing should clear that formatting gate. Please run the WebKit spec after fixing the context setup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org