You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/30 18:43:23 UTC
[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9870
to review the following change.
Change subject: thirdparty: add patch to fix printing large span stats in /memz
......................................................................
thirdparty: add patch to fix printing large span stats in /memz
This fixes a bug that I introduced upstream in gperftools by
importing the upstream patch that fixed it. The issue was mismatched
arguments to printf() which resulted in incorrect printing of stats in
/memz.
Without this fix, memz always claimed to have 128 large spans:
>128 large * 128 spans ~ 0.0 MiB; 2.7 MiB cum; unmapped: >0.0 MiB; 0.0 MiB cum
With the fix it properly reports 0 spans on startup of an empty master:
>128 large * 0 spans ~ 0.0 MiB; 3.6 MiB cum; unmapped: >0.0 MiB; 0.0 MiB cum
Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-unbreak-memz.patch
2 files changed, 30 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/9870/1
--
To view, visit http://gerrit.cloudera.org:8080/9870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
Gerrit-Change-Number: 9870
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9870 )
Change subject: thirdparty: add patch to fix printing large span stats in /memz
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
Gerrit-Change-Number: 9870
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 18:50:08 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9870 )
Change subject: thirdparty: add patch to fix printing large span stats in /memz
......................................................................
thirdparty: add patch to fix printing large span stats in /memz
This fixes a bug that I introduced upstream in gperftools by
importing the upstream patch that fixed it. The issue was mismatched
arguments to printf() which resulted in incorrect printing of stats in
/memz.
Without this fix, memz always claimed to have 128 large spans:
>128 large * 128 spans ~ 0.0 MiB; 2.7 MiB cum; unmapped: >0.0 MiB; 0.0 MiB cum
With the fix it properly reports 0 spans on startup of an empty master:
>128 large * 0 spans ~ 0.0 MiB; 3.6 MiB cum; unmapped: >0.0 MiB; 0.0 MiB cum
Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
Reviewed-on: http://gerrit.cloudera.org:8080/9870
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-unbreak-memz.patch
2 files changed, 30 insertions(+), 1 deletion(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I144830c069ec13017fd95b24aecf1489755b336f
Gerrit-Change-Number: 9870
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>