You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Olabusayo Kilo (Jira)" <ji...@apache.org> on 2022/10/09 19:09:00 UTC

[jira] [Commented] (DAFFODIL-2738) dfdlx:repType's incorrect handling of Binary Long to String enumerations

    [ https://issues.apache.org/jira/browse/DAFFODIL-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614796#comment-17614796 ] 

Olabusayo Kilo commented on DAFFODIL-2738:
------------------------------------------

* URL of your fork repo: https://hqapp01.columbia.tresys.com/okilo_bug_examples/pmmc-htn-schemas-daf-2738.git
 * branch name: daf -2738
 * test command: sbt "testOnly com.owlcyberdefense.PMMC_6017a_Regular"
 * NOTE: this reproduces the problem, but it's not a public resource and can only be accessed by logging in to the server
 * DAFFODIL HASH:  8a6898dd3a0cfaa50ae53ffc833d97b48fbb3827

Of interest is this portion of the trace for the class:
{noformat}
----------------------------------------------------------------- 499
parser: <fire_for_effect_projectile parser='StringOfSpecifiedLengthParser' />
bitPosition: 703
data:
infoset:
  <?xml version="1.0" encoding="UTF-8"?>
  <item>
    <GRI>0</GRI>
    <call_for_fire_fire_for_effect_projectile_FPI>
      <value>1</value>
    </call_for_fire_fire_for_effect_projectile_FPI>
    <fire_for_effect_projectile>P</fire_for_effect_projectile>
  </item>
diff:
  bitLimit: 1400 -> 704
  bitPosition: 696 -> 703
----------------------------------------------------------------- 500
{noformat}

> dfdlx:repType's incorrect handling of Binary Long to String enumerations
> ------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2738
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2738
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End
>    Affects Versions: 3.3.0
>            Reporter: Olabusayo Kilo
>            Priority: Major
>             Fix For: 3.4.0
>
>
> This is part of a large schema project. So link access to the schema project will follow in a different comment.
> But a short synopsis is when the repType of an element in a binary data format is an unsignedlong, the repType is ignored in favor of treating the element like a string type.
> For example:
> {code:xml}
>  
>   <xs:element name="a" type="tns:jobEnum"/>
>   <simpleType name="jobEnum" dfdlx:repType="xs:enum4">
>     <restriction base="xs:string">
>       <enumeration value="CTO" dfdlx:repValues="1"/>
>       <enumeration value="MANAGER" dfdlx:repValues="2"/>
>       <enumeration value="TEAM_LEAD" dfdlx:repValues="3"/>
>     </restriction>
>   </simpleType>
>   <xs:simpleType name="enum4" dfdl:length="4" dfdl:lengthKind="explicit" dfld:lengthUnit="bits">
>     <xs:restriction base="xs:unsignedLong"/>
>   </xs:simpleType>
> {code}
>  
> Would result in the following trace
> {code:xml}
> <Element name='a'><SpecifiedLengthExplicitParser><a parser='StringOfSpecifiedLengthParser' /></SpecifiedLengthExplicitParser><AssertExpressionEvaluationParser/></Element>
> {code}
> rather than
> {code:xml}
> <Element name='a'><SpecifiedLengthExplicitParser><a parser='Binary*SpecifiedLengthParser' /></SpecifiedLengthExplicitParser><AssertExpressionEvaluationParser/></Element>
> {code}
> Unfortunately the workaround mentioned in https://issues.apache.org/jira/browse/DAFFODIL-2596?focusedCommentId=17475017&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17475017, won't work for our usecase because the data is binary and has very specific bit length requirements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)