You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "saiintbrisson (via GitHub)" <gi...@apache.org> on 2023/05/09 16:52:48 UTC
[GitHub] [incubator-opendal] saiintbrisson opened a new pull request, #2247: chore(s3): update builder region doc
saiintbrisson opened a new pull request, #2247:
URL: https://github.com/apache/incubator-opendal/pull/2247
Fixes an outdated doc left behind after the changes made in #2234.
S3 regions are now required to build an S3 backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2247: chore(s3): update builder region doc
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2247:
URL: https://github.com/apache/incubator-opendal/pull/2247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2247: chore(s3): update builder region doc
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2247:
URL: https://github.com/apache/incubator-opendal/pull/2247#discussion_r1188924633
##########
core/src/services/s3/backend.rs:
##########
@@ -373,8 +373,7 @@ impl S3Builder {
/// Region represent the signing region of this endpoint.
///
- /// - If region is set, we will take user's input first.
- /// - If not, we will use `us-east-1` as default.
+ /// This is a required parameter.
Review Comment:
Only required for AWS S3. Other services like minio will still fallback to `us-east-1` as more of them assumed.
##########
core/src/services/s3/backend.rs:
##########
@@ -373,8 +373,7 @@ impl S3Builder {
/// Region represent the signing region of this endpoint.
///
- /// - If region is set, we will take user's input first.
- /// - If not, we will use `us-east-1` as default.
+ /// This is a required parameter.
Review Comment:
Only required for AWS S3. Other services like `minio` will still fallback to `us-east-1` as more of them assumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org