You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/16 13:20:07 UTC

[GitHub] [solr] cpoerschke opened a new pull request, #1017: NO JIRA: reduce array allocation in ExtendedDismaxQParser.UserFields

cpoerschke opened a new pull request, #1017:
URL: https://github.com/apache/solr/pull/1017

   Whilst `sed` doing the #1016 changes for SOLR-16318 some comments in `IndexSchema` cropped up and a similar approach can be used in `ExtendedDismaxQParser.UserFields` also.
   
   No JIRA ticket and `solr/CHANGES.txt` entry required in my opinion.
   
   https://github.com/apache/solr/blob/releases/solr/9.0.0/solr/core/src/java/org/apache/solr/schema/IndexSchema.java#L765-L767
   
   ```
   // Avoid creating the array twice by converting to an array first and using Arrays.sort(),
   // rather than Collections.sort() then converting to an array, since Collections.sort()
   // copies to an array first, then sets each collection member from the array.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] cpoerschke merged pull request #1017: NO JIRA: reduce array allocation in ExtendedDismaxQParser.UserFields

Posted by GitBox <gi...@apache.org>.
cpoerschke merged PR #1017:
URL: https://github.com/apache/solr/pull/1017


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org