You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrey Zagrebin (Jira)" <ji...@apache.org> on 2020/02/28 15:50:00 UTC
[jira] [Commented] (FLINK-14991) Export `FLINK_HOME` environment
variable to all the entrypoint
[ https://issues.apache.org/jira/browse/FLINK-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047753#comment-17047753 ]
Andrey Zagrebin commented on FLINK-14991:
-----------------------------------------
[~maguowei] Thanks for bringing up this idea
One more thought about it, the existing env variables are already exposed to the users giving them opportunity to rewrite the variables to arbitrary locations. Then I think we cannot easily remove them, otherwise it can break the existing deployments and will require migration on the user side. Although, I agree that the directory structure is fixed probably in 99% of use cases and having one `FLINK_HOME` environment variable should simplify user API.
One more idea is to do it in two steps:
* Check whether either `FLINK_HOME` or all currently required variables are set
* When we need to use an existing variable and it is not set then it is derived from `FLINK_HOME` as already suggested
> Export `FLINK_HOME` environment variable to all the entrypoint
> --------------------------------------------------------------
>
> Key: FLINK-14991
> URL: https://issues.apache.org/jira/browse/FLINK-14991
> Project: Flink
> Issue Type: Improvement
> Components: Command Line Client, Deployment / Scripts
> Reporter: Guowei Ma
> Priority: Minor
>
> Currently, Flink depends on 6 types of files: configuration files, system jars files, script files、library jar files, plugin jar files, and user jars files. These files are in different directories.
> Flink exports 5 environment variables to locate these different type files: `FLINK_CONF_DIR`,`FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR`.
> It is not a good style that exports an environment variable for every type of file.
> So this jira proposes to export the `FLINK_HOME` environment variable to all the entrypoint. Derive the directory of the different type files from the `FLINK_HOME` environment variable and every type file has a fixed directory name.
> This also has another benefit that the method implies the directory structure is the same in all the situations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)