You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/17 15:39:12 UTC
[GitHub] [pulsar] Demogorgon314 opened a new pull request #14354: [Function] The incrCounter method should wait it done
Demogorgon314 opened a new pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354
Fixes: #14219
### Motivation
The `incrCounter` method is a sync method, we should wait for it done.
### Modifications
Wait `incrCounterAsync` done in `incrCounter` method.
### Documentation
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
This is a bug fix, no need docs.
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin edited a comment on pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
gaozhangmin edited a comment on pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354#issuecomment-1043745607
CI failed with @Demogorgon314 related with `insertionDeletion`
```
Error: insertionDeletionWitGenericType(org.apache.pulsar.metadata.MetadataCacheTest) Time elapsed: 0.141 s <<< FAILURE!
java.lang.AssertionError: expected [Optional[{a=1, b=2}]] but found [Optional.empty]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354#issuecomment-1043735645
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354#issuecomment-1043765175
@gaozhangmin I see, this is another problem. thanks for telling me, I'll fix it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354#issuecomment-1043745607
CI failed with @Demogorgon314
```
Error: insertionDeletionWitGenericType(org.apache.pulsar.metadata.MetadataCacheTest) Time elapsed: 0.141 s <<< FAILURE!
java.lang.AssertionError: expected [Optional[{a=1, b=2}]] but found [Optional.empty]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Demogorgon314 commented on pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
Demogorgon314 commented on pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354#issuecomment-1044245698
@gaozhangmin #14373 PTAL : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14354: [Function] The incrCounter method should wait it done
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14354:
URL: https://github.com/apache/pulsar/pull/14354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org