You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "LoggingResearch (Jira)" <ji...@apache.org> on 2024/09/04 15:30:00 UTC
[jira] [Commented] (YARN-11722) Exposing Configuration Handling for Log Retention Size in LogAggregationFileController
[ https://issues.apache.org/jira/browse/YARN-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879268#comment-17879268 ]
LoggingResearch commented on YARN-11722:
----------------------------------------
To make it clear on how to fix the issue, we upload the comparison between the original version and the log-enhanced version in the attached file `original-vs-log-enhanced.md`. The log-enhanced version is generated automatically utilizing our proposed tool.
> Exposing Configuration Handling for Log Retention Size in LogAggregationFileController
> --------------------------------------------------------------------------------------
>
> Key: YARN-11722
> URL: https://issues.apache.org/jira/browse/YARN-11722
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 3.3.6
> Environment: Version: {{3.3.6}}
> Location: {{{}hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LogAggregationFileController.java{}}}, in the {{initialize}} method, lines 118-130.
> Reporter: LoggingResearch
> Priority: Major
> Attachments: TestLogAggregationFileControllerFactory.java, original-vs-log-enhanced.md
>
>
> When configuring the log aggregation retention size using {{{}yarn.nodemanager.log-aggregation.num-log-files-per-app{}}}, users may mistakenly set the value to a non-positive integer, expecting it to work without issues. However, this misconfiguration is silently corrected by defaulting to a predefined retention size of 30. This silent handling can lead to confusion as there is no system output indicating the correction, leaving users unaware of the actual configuration being applied.
>
> *Expected Behavior:*
> The system should provide log output to inform users about the applied default retention size when an invalid value is configured.
>
> *How-to-Fix:*
> We propose exposing the handling of invalid retention size values by adding logging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org