You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/11/27 21:47:14 UTC

[PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.4, support jdk21 [calcite-avatica]

snuyanzin opened a new pull request, #234:
URL: https://github.com/apache/calcite-avatica/pull/234

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.5, support jdk21 [calcite-avatica]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#issuecomment-2019841937

   Do you plan to merge this @snuyanzin  ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.4, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#discussion_r1406788369


##########
gradle.properties:
##########
@@ -51,10 +51,12 @@ org.owasp.dependencycheck.version=5.2.2
 # Tools
 checkerframework.version=3.10.0
 checkstyle.version=10.3.2
+jdk8.checkstyle.version=9.3
 spotbugs.version=3.1.11
 
 asm.version=7.1
 bouncycastle.version=1.70
+bytebuddy.version=1.14.10

Review Comment:
   bytebuddy which came with mockito does not support java 21



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.4, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#discussion_r1406785789


##########
gradle/wrapper/gradle-wrapper.properties:
##########
@@ -16,8 +16,8 @@
 #
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionSha256Sum=e111cb9948407e26351227dabce49822fb88c37ee72f1d1582a69c68af2e702f
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
+distributionSha256Sum=3e1af3ae886920c3ac87f7a91f816c0c7c436f276a6eefdb3da152100fef72ae

Review Comment:
   taken from https://gradle.org/release-checksums/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.5, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.5, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#issuecomment-2021482264

   squashed commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.4, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#discussion_r1406786810


##########
gradlew:
##########
@@ -85,9 +85,6 @@ done
 APP_BASE_NAME=${0##*/}
 APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit
 
-# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.

Review Comment:
   every change in this file is a result of command `./gradlew  wrapper --gradle-version 8.4`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CALCITE-6137] Upgrade Gradle from 8.1.1 to 8.5, support jdk21 [calcite-avatica]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #234:
URL: https://github.com/apache/calcite-avatica/pull/234#issuecomment-2020392878

   Thanks for the reminder and thanks for the review
   sorry for the delay
   
   I just added a note about JDK 21 in `history.md` as it was asked in jira
   
   I will merge it today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org