You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/18 07:41:21 UTC

[GitHub] [superset] zhaoyongjie commented on pull request #12575: fix: return appropriate response when payload has error

zhaoyongjie commented on pull request #12575:
URL: https://github.com/apache/superset/pull/12575#issuecomment-762050802


   @villebro 
   Because `get_samples` always contains columns key in `query_obj`,  so `get_sample` will always return a `dataframe`.
   
   https://github.com/apache/superset/blob/0f243c6ddd2860ba475ba205eb5bfd836833a9a8/superset/viz.py#L246-L258


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org