You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/15 02:24:19 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull
request #4695: [Resource Assignment] Plug in resource assignment to LLC
REALTIME table
Jackie-Jiang commented on a change in pull request #4695: [Resource Assignment] Plug in resource assignment to LLC REALTIME table
URL: https://github.com/apache/incubator-pinot/pull/4695#discussion_r334728552
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/assignment/InstancePartitionsUtils.java
##########
@@ -89,18 +91,32 @@ public static InstancePartitions fetchInstancePartitions(HelixPropertyStore<ZNRe
}
/**
- * Computes the default instance partitions.
- * <p>For backward-compatibility, sort all enabled instances with the server tag, rotate the list based on the table
- * name name to prevent creating hotspot servers.
+ * Computes the default instance partitions. Sort all qualified instances and rotate the list based on the table name
+ * to prevent creating hotspot servers.
+ * <p>For backward-compatibility, choose only enabled instances with the server tag for OFFLINE table; choose both
Review comment:
Very good suggestion. Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org