[jira] [Comment Edited] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115837#comment-16115837 ] 

Jacques Le Roux edited comment on OFBIZ-9441 at 8/6/17 3:38 PM:
----------------------------------------------------------------

3. Right
4 Yep I thought so, just tried again with 
bq. g cleanAll eclipse build "ofbiz -l readers=seed,demo,ext -l delegator=default -l group=org.apache.ofbiz"
same errors than with
bq. java -jar build/libs/ofbiz.jar -l readers=seed,demo,ext
5. You mean that it's about the order (because loadAll works)? Of course using 
bq. g cleanAll eclipse build "ofbiz -l readers=seed,demo,ext"
I get the same errors again.

Forgot mention that I completed the review and all sounds good to me.




was (Author: jacques.le.roux):
3. Right
4 Yep I thought so, just tried again with 
bq. g cleanAll eclipse build "ofbiz -l readers=seed,demo,ext -l delegator=default -l group=org.apache.ofbiz"
same errors than with
bq. java -jar build/libs/ofbiz.jar -l readers=seed,demo,ext
5. You mean that it's about the order (because loadAll works)? Of course using 
bq. g cleanAll eclipse build "ofbiz -l readers=seed,demo,ext"
I get the same errors again.

For got mention that I completed the review and all sounds good to me.



> Refactor OFBiz containers and remove StartupCommandToArgsAdapter
> ----------------------------------------------------------------
>
>                 Key: OFBIZ-9441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9441
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Taher Alkhateeb
>            Assignee: Taher Alkhateeb
>            Priority: Minor
>         Attachments: log with errors.txt, OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, OFBIZ-9441.patch
>
>
> We have already refactored the ComponentContainer and CatalinaContainer in OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the following:
> - Refactor EntityDataLoadContainer to simplify the code and remove dependencies on "args" and convert instead the logic to use StartupCommands
> - Refactor TestRunContainer the same way
> - Delete the class StartupCommandToArgsAdapter
> - Update README.md to reflect the changes and updates and cleanup old references.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)