You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by rg...@apache.org on 2022/03/11 04:35:45 UTC

[pulsar] 02/06: [Flaky-test]: Fix MLTransactionMetadataStoreTest.testInitTransactionReader fails sporadically (#14532)

This is an automated email from the ASF dual-hosted git repository.

rgao pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit 5a03b36e575e311a018606153f2b93fda3dca192
Author: 包子 <wu...@gmail.com>
AuthorDate: Thu Mar 3 16:36:54 2022 +0800

    [Flaky-test]: Fix MLTransactionMetadataStoreTest.testInitTransactionReader fails sporadically (#14532)
    
    ### Motivation
    
    #14525
    
    When update states is `TxnStatus.COMMITTED`,  Not correctly `completableFuture.complete`.
    
    ### Modifications
    - When update states is `TxnStatus.COMMITTED`, Add return to ending. Avoid direct calls `completableFuture.complete` from other logic.
    
    ### Documentation
    - [x ] `no-need-doc`
    
    (cherry picked from commit c15d0ef24e37df6b86bc8f4c27d43af27f8cc663)
---
 .../pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java b/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
index f109ec4..eabb5fb 100644
--- a/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
+++ b/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java
@@ -391,6 +391,7 @@ public class MLTransactionMetadataStore
                                 txnMetaMap.remove(txnID.getLeastSigBits());
                                 completableFuture.complete(null);
                             });
+                            return;
                         }
                         completableFuture.complete(null);
                     } catch (InvalidTxnStatusException e) {