You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/03/20 09:37:20 UTC

Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3672
    https://issues.apache.org/jira/browse/ATLAS-3672


Repository: atlas


Description
-------

As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
During fetching it was taking qualifiedName .name as the propertyKey


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 


Diff: https://reviews.apache.org/r/72253/diff/1/


Testing
-------

Manually tested below scenario:
1) add Entity and Entity Filters
2) add classification


Thanks,

Pinal Shah

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220148
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On March 31, 2020, 10:45 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> -----------------------------------------------------------
> 
> (Updated March 31, 2020, 10:45 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3672
>     https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

Posted by Pinal Shah <pi...@freestoneinfotech.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/
-----------------------------------------------------------

(Updated March 31, 2020, 10:45 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

removed unwanted check


Bugs: ATLAS-3672
    https://issues.apache.org/jira/browse/ATLAS-3672


Repository: atlas


Description
-------

As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
During fetching it was taking qualifiedName .name as the propertyKey


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 


Diff: https://reviews.apache.org/r/72253/diff/2/

Changes: https://reviews.apache.org/r/72253/diff/1-2/


Testing
-------

Manually tested below scenario:
1) add Entity and Entity Filters
2) add classification


Thanks,

Pinal Shah

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220144
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3672
>     https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

Posted by Pinal Shah <pi...@freestoneinfotech.com>.


> On March 31, 2020, 9:12 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
> > Line 737 (original), 737 (patched)
> > <https://reviews.apache.org/r/72253/diff/1/?file=2214312#file2214312line737>
> >
> >     attr.getVertexPropertyName()  will not be null for any attribute; so no need to check and fall back to attr.getQualifiedName().

As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
attr.getQualifiedName() will not solve purpose.


- Pinal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220143
-----------------------------------------------------------


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3672
>     https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72253: ATLAS-3672 : Search with Classification without filters and Entity with filters doesn't fetch expected results.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72253/#review220143
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 737 (original), 737 (patched)
<https://reviews.apache.org/r/72253/#comment308466>

    attr.getVertexPropertyName()  will not be null for any attribute; so no need to check and fall back to attr.getQualifiedName().


- Madhan Neethiraj


On March 20, 2020, 9:37 a.m., Pinal Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72253/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 9:37 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3672
>     https://issues.apache.org/jira/browse/ATLAS-3672
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> As the vertexPropertyName of "name" attribute is changed to prefix '__s_name' for graphdb
> During fetching it was taking qualifiedName .name as the propertyKey
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ddd3e60d2 
> 
> 
> Diff: https://reviews.apache.org/r/72253/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested below scenario:
> 1) add Entity and Entity Filters
> 2) add classification
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>