You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/11 02:38:25 UTC
Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
This is what I have so far.
We need to fix the TODOs inside runTask() before we can call it complete.
Diffs
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
Diff: https://reviews.apache.org/r/10413/diff/
Testing
-------
sudo ./bin/mesos-tests.sh --gtest_filter="*MasterTest*:*GCExecutor*" --verbose
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 17, 2013, 1:19 a.m., Ben Mahler wrote:
> > src/tests/gc_tests.cpp, line 699
> > <https://reviews.apache.org/r/10413/diff/3/?file=281489#file281489line699>
> >
> > Can you try using InSequence to get around this?
I tried it, but it gets ugly because InSequence operates by enforcing the order of expecting statements in a block. Since we capture the return of FUTURE_DISPATCHs in Futures, we need that block to enclose the rest of the test. But this means it also enforces order for all other expectations that follow the FUTURE_DISPATCHs :/ So, I'm leaving it as is.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/#review19291
-----------------------------------------------------------
On April 16, 2013, 1:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10413/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 1:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> This is what I have so far.
>
> We need to fix the TODOs inside runTask() before we can call it complete.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
> src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d
>
> Diff: https://reviews.apache.org/r/10413/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --verbose --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* --gtest_repeat=1000
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/#review19291
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/10413/#comment39963>
kill the comment
src/slave/slave.cpp
<https://reviews.apache.org/r/10413/#comment39964>
s/Remvoe/Remove
Didn't I see this already?
src/slave/slave.cpp
<https://reviews.apache.org/r/10413/#comment39966>
TODO to this logic to the Executor struct?
src/slave/slave.cpp
<https://reviews.apache.org/r/10413/#comment39965>
const string& if it works nicely in this function
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10413/#comment39967>
kill meta?
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10413/#comment39968>
Can we move this inside MesosTest? MesosClusterTest?
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10413/#comment39969>
Can you try using InSequence to get around this?
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10413/#comment39970>
Kill the VLOG, ditto above and below.
- Ben Mahler
On April 16, 2013, 1:45 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10413/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 1:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> This is what I have so far.
>
> We need to fix the TODOs inside runTask() before we can call it complete.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
> src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d
>
> Diff: https://reviews.apache.org/r/10413/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --verbose --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* --gtest_repeat=1000
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/
-----------------------------------------------------------
(Updated April 17, 2013, 6:41 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
comments and rebase. no need for review.
Description
-------
This is what I have so far.
We need to fix the TODOs inside runTask() before we can call it complete.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/tests/gc_tests.cpp 872faa74d7a4b71ea4e89d73f450b24c5031e876
Diff: https://reviews.apache.org/r/10413/diff/
Testing
-------
sudo ./bin/mesos-tests.sh --verbose --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* --gtest_repeat=1000
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/
-----------------------------------------------------------
(Updated April 16, 2013, 1:45 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased over upstream changes.
Description
-------
This is what I have so far.
We need to fix the TODOs inside runTask() before we can call it complete.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d
Diff: https://reviews.apache.org/r/10413/diff/
Testing
-------
sudo ./bin/mesos-tests.sh --verbose --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* --gtest_repeat=1000
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/
-----------------------------------------------------------
(Updated April 15, 2013, 10:45 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
fixed unschedule chaining.
also, took care of properly unscheduling framework/executor directories.
Description
-------
This is what I have so far.
We need to fix the TODOs inside runTask() before we can call it complete.
Diffs (updated)
-----
src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d
Diff: https://reviews.apache.org/r/10413/diff/
Testing (updated)
-------
sudo ./bin/mesos-tests.sh --verbose --gtest_filter=*GarbageCollectorIntegrationTest.Unschedule* --gtest_repeat=1000
Thanks,
Vinod Kone
Re: Review Request: Fixed slave to properly schedule/unschedule top level
executor directories for garbage collection.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10413/#review19039
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/10413/#comment39563>
unschedule = unschedule.then()
here and below.
- Vinod Kone
On April 11, 2013, 12:38 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10413/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 12:38 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> This is what I have so far.
>
> We need to fix the TODOs inside runTask() before we can call it complete.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0
> src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa
>
> Diff: https://reviews.apache.org/r/10413/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --gtest_filter="*MasterTest*:*GCExecutor*" --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>