You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/21 10:03:06 UTC
[GitHub] [tvm] jchia opened a new pull request #7320: Made tensorflow IsNan actually work
jchia opened a new pull request #7320:
URL: https://github.com/apache/tvm/pull/7320
IsNan was added to tensorflow.rst in fa1b859f but this commit makes IsNan actually work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
jchia edited a comment on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518
> Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
I'm not familiar with the code base, but I think the test will be similar to `test_forward_isinf()` in `tests/python/frontend/tensorflow/test_forward.py`. Is that the right approach? I'm not sure how to run the test properly on my dev machine, though and it keeps failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
jchia edited a comment on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7320:
URL: https://github.com/apache/tvm/pull/7320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
jchia edited a comment on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518
> Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
I'm not familiar with the code base, but I think the test will be similar to `test_forward_isinf()` in `tests/python/frontend/tensorflow/test_forward.py`. Is that the right approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764707942
> > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
>
> I'm not familiar with the code base, but I think the test will be similar to `test_forward_isinf()` in `tests/python/frontend/tensorflow/test_forward.py`. Is that the right approach?
cc @anijain2305 @siju-samuel @zhiics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jchia commented on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
jchia commented on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518
> Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
I'm not familiar with the code base. Where can I add this test? I tried following the example of IsInf, but it seems that IsInf doesn't have an analogous test. Is there another function that has an analogous test that I can use as a reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764674422
Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jchia commented on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
jchia commented on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518
> Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
I'm not familiar with the code base. Where can I add this test? I tried following the example of IsInf, but it seems that IsInf doesn't have an analogous test. Is there another function that has an analogous test that I can use as a reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7320:
URL: https://github.com/apache/tvm/pull/7320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #7320: Made tensorflow IsNan actually work
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764674422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org