[jira] [Commented] (CURATOR-408) Handle graceful close of ZookKeeper client waiting for all resources to be released

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CURATOR-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507386#comment-16507386 ] 

ASF GitHub Bot commented on CURATOR-408:
----------------------------------------

GitHub user eolivelli opened a pull request:

    https://github.com/apache/curator/pull/266

    CURATOR-408 Handle graceful close of ZookKeeper client waiting for all resources to be released

    Add a new close(int timeout) API in order to leverage ZooKeeper#close(timeout) API introduced in ZK 4.5.4-BETA.
    
    Summary of changes:
    - bump ZK to 4.5.4-BETA
    - add the implementation of the feature
    - add a missing license header

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/curator fix/CURATOR-408-close-with-timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
    
----
commit 07ad0789782f2c0daadd5cce4aa194f42e24ad13
Author: Enrico Olivelli <en...@...>
Date:   2018-06-10T13:31:29Z

    CURATOR-408 Handle graceful close of ZookKeeper client waiting for all resources to be released

----


> Handle graceful close of ZookKeeper client waiting for all resources to be released
> -----------------------------------------------------------------------------------
>
>                 Key: CURATOR-408
>                 URL: https://issues.apache.org/jira/browse/CURATOR-408
>             Project: Apache Curator
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 4.0.0
>            Reporter: Enrico Olivelli
>            Assignee: Enrico Olivelli
>            Priority: Major
>
> Ths idea is to leverage the new ZooKeeper#close(timeoutMs) method introduced with ZOOKEEPER-2697.
> This new method waits for the internal threads to finish, this way the client is sure that all internal resources handled but low-level ZooKeeper client have been released.
> This is very useful in tests because the user can wait for the test environment to be cleared.
> In some cases you want to return from the 'close' method as soon as possibile. In ZooKeeper a new specific method as been added in order to let the user ask for a specific behaviour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)