You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2016/07/13 07:01:29 UTC
[trafficserver] branch master updated: Format
HttpTransact::is_request_valid() debug logs consistently.
This is an automated email from the ASF dual-hosted git repository.
jpeach pushed a commit to branch master
in repository https://git-dual.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new 263672c Format HttpTransact::is_request_valid() debug logs consistently.
263672c is described below
commit 263672c628ffa57c92733b16c1ee549f58480ac4
Author: James Peach <jp...@apache.org>
AuthorDate: Wed Jul 13 16:59:29 2016 +1000
Format HttpTransact::is_request_valid() debug logs consistently.
---
proxy/http/HttpTransact.cc | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index e7dde35..a83bc34 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -6425,12 +6425,10 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request)
incoming_error = check_request_validity(s, incoming_request);
switch (incoming_error) {
case NO_REQUEST_HEADER_ERROR:
- DebugTxn("http_trans", "[is_request_valid]"
- "no request header errors");
+ DebugTxn("http_trans", "[is_request_valid] no request header errors");
break;
case FAILED_PROXY_AUTHORIZATION:
- DebugTxn("http_trans", "[is_request_valid]"
- "failed proxy authorization");
+ DebugTxn("http_trans", "[is_request_valid] failed proxy authorization");
SET_VIA_STRING(VIA_DETAIL_TUNNEL, VIA_DETAIL_TUNNEL_NO_FORWARD);
build_error_response(s, HTTP_STATUS_PROXY_AUTHENTICATION_REQUIRED, "Proxy Authentication Required",
"access#proxy_auth_required", NULL);
@@ -6438,8 +6436,7 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request)
case NON_EXISTANT_REQUEST_HEADER:
/* fall through */
case BAD_HTTP_HEADER_SYNTAX: {
- DebugTxn("http_trans", "[is_request_valid]"
- "non-existant/bad header");
+ DebugTxn("http_trans", "[is_request_valid] non-existant/bad header");
SET_VIA_STRING(VIA_DETAIL_TUNNEL, VIA_DETAIL_TUNNEL_NO_FORWARD);
build_error_response(s, HTTP_STATUS_BAD_REQUEST, "Invalid HTTP Request", "request#syntax_error", NULL);
return false;
@@ -6474,24 +6471,20 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request)
return false;
case SCHEME_NOT_SUPPORTED:
case NO_REQUEST_SCHEME: {
- DebugTxn("http_trans", "[is_request_valid] unsupported "
- "or missing request scheme");
+ DebugTxn("http_trans", "[is_request_valid] unsupported or missing request scheme");
SET_VIA_STRING(VIA_DETAIL_TUNNEL, VIA_DETAIL_TUNNEL_NO_FORWARD);
build_error_response(s, HTTP_STATUS_BAD_REQUEST, "Unsupported URL Scheme", "request#scheme_unsupported", NULL);
return false;
}
/* fall through */
case METHOD_NOT_SUPPORTED:
- DebugTxn("http_trans", "[is_request_valid]"
- "unsupported method");
+ DebugTxn("http_trans", "[is_request_valid] unsupported method");
s->current.mode = TUNNELLING_PROXY;
return true;
case BAD_CONNECT_PORT:
int port;
port = url ? url->port_get() : 0;
- DebugTxn("http_trans", "[is_request_valid]"
- "%d is an invalid connect port",
- port);
+ DebugTxn("http_trans", "[is_request_valid] %d is an invalid connect port", port);
SET_VIA_STRING(VIA_DETAIL_TUNNEL, VIA_DETAIL_TUNNEL_NO_FORWARD);
build_error_response(s, HTTP_STATUS_FORBIDDEN, "Tunnel Forbidden", "access#connect_forbidden", NULL);
return false;
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].