You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/09 11:34:23 UTC
[I] Remove dead amber engine files with no production caller [texera]
aglinxinyuan opened a new issue, #7445:
URL: https://github.com/apache/texera/issues/7445
### Task Summary
Four amber files have no production caller. Each is self-contained, so removing them touches no surviving file.
| File | Lines | Why it is dead |
| --- | ---: | --- |
| `engine/common/ElidableStatement.scala` (+ spec) | 34 + 141 | no caller; `elidable` appears nowhere else in the repo, including scalac options |
| `engine/architecture/logreplay/EmptyReplayLogger.scala` (+ spec) | 41 + 130 | null-object superseded by `EmptyReplayLogManagerImpl` |
| `web/model/http/response/SchemaPropagationResponse.scala` | 28 | no resource returns it; one repo-wide hit, itself |
| `engine/architecture/pythonworker/PythonWorkflowWorkerSpec.scala` | 201 | every line is commented out — including `package` |
`EmptyReplayLogger` was a no-op `ReplayLogger`. The factory no longer reaches it: `ReplayLogManager.scala:51` returns `EmptyReplayLogManagerImpl`, which implements the no-ops inline, and line 109 shows the only `ReplayLogger` built anywhere in main is `new ReplayLoggerImpl()`.
```
ReplayLogManager -> EmptyReplayLogManagerImpl (inline no-ops, live)
-> ReplayLogManagerImpl -> new ReplayLoggerImpl() (live)
EmptyReplayLogger (never instantiated)
```
`PythonWorkflowWorkerSpec` contributes zero test suites — it compiles to a licence header. Its commented body targets APIs deleted long ago (`InitializeOperatorLogicHandler`, `UpdateInputLinkingHandler`, `OpenOperator`), so it cannot be un-commented. Live `PythonWorkflowWorker` coverage lives in the `@IntegrationTest` e2e specs, which this file does not participate in.
Pure deletion, no behaviour change: −575 lines.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove dead amber engine files with no production caller [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #7445:
URL: https://github.com/apache/texera/issues/7445#issuecomment-5231302698
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @aglinxinyuan!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the fully commented-out PythonWorkflowWorkerSpec [texera]
Posted by "roshiiiz (via GitHub)" <gi...@apache.org>.
roshiiiz commented on issue #7445:
URL: https://github.com/apache/texera/issues/7445#issuecomment-5376091102
/untake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove the fully commented-out PythonWorkflowWorkerSpec [texera]
Posted by "roshiiiz (via GitHub)" <gi...@apache.org>.
roshiiiz commented on issue #7445:
URL: https://github.com/apache/texera/issues/7445#issuecomment-5376064498
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org