You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/29 00:27:44 UTC
[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18188: update version select drop down
ys2843 opened a new pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188
## Description ##
According to this issue https://github.com/apache/incubator-mxnet/issues/16059
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-623722754
@mxnet-label-bot add [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620993509
@connorgoggins Thank you for the feedback. Hover for sure gives a good ux, not to mention the consistency. The only problem I was trying to avoid is not to let the drop down content overlap the buttons below it during unintentional hover ( and the content area is much larger than before).
Here is my another solution, please let me know how do you like it. I added a 250ms delay to the hover effect so that any unintentional hover will not show the drop down content. Also caret is aligned.
+ Preview updated, let's checkout the new effect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-623588942
@ys2843
http://ec2-34-216-15-136.us-west-2.compute.amazonaws.com/
https://ec2-34-216-15-136.us-west-2.compute.amazonaws.com/
Both give error.
<img width="860" alt="Screen Shot 2020-05-04 at 10 09 04 AM" src="https://user-images.githubusercontent.com/10992635/80993082-515d7180-8def-11ea-9056-8447d1b14f1f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622436787
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622234277
@mxnet-label-bot update [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622125843
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622525459
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621363991
Amazing - it looks great! Thanks for your excellent work on this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 edited a comment on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 edited a comment on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622036580
@aaronmarkham Yes, tested on all main stream browser including Firefox, Chrome, Safari and Edge, it works well. I think older IE should also be good, because it is simple JQuery DOM manipulation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622125787
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-623597733
@ChaiBapchya Thanks for reviewing! Updated the preview link, please see http://ec2-54-191-240-239.us-west-2.compute.amazonaws.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622525419
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621479628
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621479681
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621333110
@connorgoggins Thank you for testing this! This is a good one. I fixed the bug and made the dropdown content close after user clicking an option.
The preview is updated, please let me know if there is any problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ChaiBapchya removed a comment on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-623722754
@mxnet-label-bot add [pr-awaiting-merge]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: [website] update version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620928833
@mxnet-label-bot update [website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] connorgoggins commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620934451
Thanks so much for your work on this, Yang! Nice addition of the caret to the dropdown menu! Also good job switching to the wider menu layout - the width looks much better than before.
A couple things: I personally don't like the fact that the user has to click on the menu to show the options. Not sure this is a good change to make if we're going for a smooth user experience. I think the version dropdown for install should work the same as the version dropdown menu for the general website: options displayed on hover.
I'm also not sure that using a scrollable window for the menu content is preferable when the full menu can be easily displayed on my screen, and the scroll window partially cuts off other options. Open to discuss this if folks have other opinions though.
Also, for me the caret isn't aligned properly:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620922870
Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, windows-cpu, windows-gpu, unix-gpu, unix-cpu, sanity, miscellaneous, centos-cpu, centos-gpu, clang, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622436754
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 removed a comment on pull request #18188: [website] update version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 removed a comment on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620928764
@mxnet-label-bot update [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] apeforest commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
apeforest commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-621489428
@aaronmarkham your review will be appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622654275
@mxnet-bot run ci [windows-gpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622250705
@leezu Thank you very much for reviewing. Really a good point. Fixed mobile incompatible issue by listening to click to toggle the dropdown contents. Tested the fix on laptop and mobile in different browsers. Please see preview, let me know if there is problem. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622036580
@aaronmarkham Yes, tested on all main stream browser including Firefox, Chrome, Safari and Edge, it works well. I think older IE should also be good, because it is just simple JQuery DOM manipulation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622654291
Jenkins CI successfully triggered : [unix-gpu, windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] aaronmarkham commented on pull request #18188: update website version select drop down
Posted by GitBox <gi...@apache.org>.
aaronmarkham commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-622007256
Did you test this across browsers? At least getting it to work with 80%+ of visitors' configs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: [website] update version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620928764
@mxnet-label-bot update [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ys2843 commented on pull request #18188: [website] update version select drop down
Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18188:
URL: https://github.com/apache/incubator-mxnet/pull/18188#issuecomment-620929100
@mxnet-label-bot add [website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org