[GitHub] [arrow-rs] viirya commented on a diff in pull request #1731: Fix schema comparison for non_canonical_map when running flight test

[GitBox <gi...@apache.org>]

viirya commented on code in PR #1731:
URL: https://github.com/apache/arrow-rs/pull/1731#discussion_r879744316


##########
integration-testing/src/flight_client_scenarios/integration_test.rs:
##########
@@ -215,7 +215,7 @@ async fn consume_flight_location(
             flight_data_to_arrow_batch(&data, actual_schema.clone(), &dictionaries_by_id)
                 .expect("Unable to convert flight data to Arrow batch");
 
-        assert_eq!(expected_batch.schema(), actual_batch.schema());
+        assert_eq!(actual_schema, actual_batch.schema());

Review Comment:
   `expected_batch`'s schema is uploaded one. The flight server could make cosmetic change to the schema.
   
   `actual_schema` is received from flight. We should take it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org