[GitHub] [tvm] leandron commented on a diff in pull request #11228: [QNN] Enable constant folding for QNN operations.

[GitBox <gi...@apache.org>]

leandron commented on code in PR #11228:
URL: https://github.com/apache/tvm/pull/11228#discussion_r866763690


##########
python/tvm/relay/transform/transform.py:
##########
@@ -261,32 +261,39 @@ def LazyGradientInit():
     return _ffi_api.LazyGradientInit()
 
 
-def FoldConstantExpr(expr, mod):
+def FoldConstantExpr(expr, mod, fold_qnn=False):
     """Fold the constant expressions in a Relay program.
     Parameters
     ----------
     expr: Expr
         The expression to fold
     mod: IRModule
         The module the expr lives in (for global calls)
+    fskip: bool

Review Comment:
   The argument name here doesn't match with the one in the function. Please review the other ones as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org