[GitHub] [beam] damccorm commented on a diff in pull request #23162: [GitHub Actions] - Updates in Playground Deploy Examples to runs-on Self-hosted runners

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #23162:
URL: https://github.com/apache/beam/pull/23162#discussion_r969741537


##########
.github/workflows/playground_deploy_examples.yml:
##########
@@ -26,23 +25,33 @@ env:
   BEAM_VERSION: 2.40.0
   K8S_NAMESPACE: playground-backend
   HELM_APP_NAME: playground-backend
+permissions: read-all
 jobs:
   check_examples:
     name: Check examples
-    runs-on: ubuntu-latest
+    runs-on: [self-hosted, ubuntu-20.04]
     outputs:
       example_has_changed: ${{ steps.check_has_example.outputs.example_has_changed }}
     steps:
       - name: Check out the repo
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
+          ref: ${{ github.event.pull_request.head.sha }}
       - uses: actions/setup-python@v4
         with:
           python-version: '3.8'
       - name: install deps
         run: pip install -r requirements.txt
         working-directory: playground/infrastructure
+      - name: Install PowerShell

Review Comment:
   Rather than installing powershell, can we just convert the `pwsh` block below to a more generic script block? It isn't doing anything that a bash shell shouldn't be able to do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org