You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/07/12 12:39:00 UTC
[commons-io] branch master updated (cf3ebc7 -> d269f16)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git.
from cf3ebc7 Add tests to BrokenWriterTest.
new 835a8d4 Add tests to BrokenWriterTest.
new d269f16 Minor refactorings.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../commons/io/input/UncheckedBufferedReader.java | 24 +++++++++++++---------
.../commons/io/input/UncheckedFilterReader.java | 22 ++++++++++++--------
.../apache/commons/io/output/BrokenWriterTest.java | 12 +++++++++++
3 files changed, 39 insertions(+), 19 deletions(-)
[commons-io] 02/02: Minor refactorings.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit d269f164b3e24a92cc33d759d8bcf3eedb37f576
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jul 12 08:38:55 2021 -0400
Minor refactorings.
---
.../commons/io/input/UncheckedBufferedReader.java | 24 +++++++++++++---------
.../commons/io/input/UncheckedFilterReader.java | 22 ++++++++++++--------
2 files changed, 27 insertions(+), 19 deletions(-)
diff --git a/src/main/java/org/apache/commons/io/input/UncheckedBufferedReader.java b/src/main/java/org/apache/commons/io/input/UncheckedBufferedReader.java
index 8aebc2a..4966852 100644
--- a/src/main/java/org/apache/commons/io/input/UncheckedBufferedReader.java
+++ b/src/main/java/org/apache/commons/io/input/UncheckedBufferedReader.java
@@ -73,7 +73,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
super.close();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -85,7 +85,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
super.mark(readAheadLimit);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -97,7 +97,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.read();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -109,7 +109,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.read(cbuf);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -121,7 +121,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.read(cbuf, off, len);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -133,7 +133,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.read(target);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -145,7 +145,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.readLine();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -157,7 +157,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.ready();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -169,7 +169,7 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
super.reset();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -181,8 +181,12 @@ public class UncheckedBufferedReader extends BufferedReader {
try {
return super.skip(n);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
+ private UncheckedIOException uncheck(final IOException e) {
+ return new UncheckedIOException(e);
+ }
+
}
diff --git a/src/main/java/org/apache/commons/io/input/UncheckedFilterReader.java b/src/main/java/org/apache/commons/io/input/UncheckedFilterReader.java
index a3a7acd..285bc94 100644
--- a/src/main/java/org/apache/commons/io/input/UncheckedFilterReader.java
+++ b/src/main/java/org/apache/commons/io/input/UncheckedFilterReader.java
@@ -62,7 +62,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
super.close();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -74,7 +74,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
super.mark(readAheadLimit);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -86,7 +86,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.read();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -98,7 +98,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.read(cbuf);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -110,7 +110,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.read(cbuf, off, len);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -122,7 +122,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.read(target);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -134,7 +134,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.ready();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -146,7 +146,7 @@ public class UncheckedFilterReader extends FilterReader {
try {
super.reset();
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
@@ -158,8 +158,12 @@ public class UncheckedFilterReader extends FilterReader {
try {
return super.skip(n);
} catch (final IOException e) {
- throw new UncheckedIOException(e);
+ throw uncheck(e);
}
}
+ private UncheckedIOException uncheck(final IOException e) {
+ return new UncheckedIOException(e);
+ }
+
}
[commons-io] 01/02: Add tests to BrokenWriterTest.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 835a8d4e1eaf880b7a038405fb1346d9dfa2106c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Jul 12 08:38:40 2021 -0400
Add tests to BrokenWriterTest.
---
.../java/org/apache/commons/io/output/BrokenWriterTest.java | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/test/java/org/apache/commons/io/output/BrokenWriterTest.java b/src/test/java/org/apache/commons/io/output/BrokenWriterTest.java
index de0422a..bc0e125 100644
--- a/src/test/java/org/apache/commons/io/output/BrokenWriterTest.java
+++ b/src/test/java/org/apache/commons/io/output/BrokenWriterTest.java
@@ -62,12 +62,24 @@ public class BrokenWriterTest {
}
@Test
+ @Disabled("What should happen here?")
+ public void testEquals() {
+ assertEquals(exception, assertThrows(IOException.class, () -> brokenWriter.equals(null)));
+ }
+
+ @Test
public void testFlush() {
assertEquals(exception, assertThrows(IOException.class, () -> brokenWriter.flush()));
}
@Test
@Disabled("What should happen here?")
+ public void testHashCode() {
+ assertEquals(exception, assertThrows(IOException.class, () -> brokenWriter.hashCode()));
+ }
+
+ @Test
+ @Disabled("What should happen here?")
public void testToString() {
assertEquals(exception, assertThrows(IOException.class, () -> brokenWriter.toString()));
}