You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/02 14:46:33 UTC

[GitHub] [airflow] efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration

efolgar commented on a change in pull request #6169: [AIRFLOW-4970][Don't merge] Add Google Campaign Manager integration
URL: https://github.com/apache/airflow/pull/6169#discussion_r330553139
 
 

 ##########
 File path: airflow/gcp/operators/campaign_manager.py
 ##########
 @@ -0,0 +1,382 @@
+# -*- coding: utf-8 -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+This module contains Google CampaignManager operators.
+"""
+import tempfile
+from typing import Any, Dict, Optional
+import uuid
+
+from googleapiclient import http
+
+from airflow import AirflowException
+from airflow.gcp.hooks.gcs import GoogleCloudStorageHook
+from airflow.gcp.hooks.campaign_manager import GoogleCampaignManagerHook
+from airflow.models.baseoperator import BaseOperator
+from airflow.utils.decorators import apply_defaults
+
+
+class GoogleCampaignManagerDeleteReportOperator(BaseOperator):
+    """
+    Deletes a report by its ID.
 
 Review comment:
   Class docstring should be updated to include report_name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services