[GitHub] [kafka] dengziming commented on a change in pull request #11173: KAFKA-13509: Support max timestamp in GetOffsetShell

[GitBox <gi...@apache.org>]

dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r763752790



##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -72,10 +73,10 @@ object GetOffsetShell {
                            .ofType(classOf[String])
     val timeOpt = parser.accepts("time", "timestamp of the offsets before that. [Note: No offset is returned, if the timestamp greater than recently committed record timestamp is given.]")
                            .withRequiredArg
-                           .describedAs("timestamp/-1(latest)/-2(earliest)")
+                           .describedAs("timestamp/-1(latest)/-2(earliest)/-3(max timestamp)")
                            .ofType(classOf[java.lang.Long])
                            .defaultsTo(-1L)
-    val commandConfigOpt = parser.accepts("command-config", s"Property file containing configs to be passed to Consumer Client.")
+    val commandConfigOpt = parser.accepts("command-config", s"Property file containing configs to be passed to Admin Client.")

Review comment:
       @showuon , Thank you for your remainders, I inspected `AdminClientConfig` carefully and I found the only config not presented in `ConsumerConfig` is `RETRIES_CONFIG`, and those consumer configs which can't work with admin config will be ignored. So, fortunately, this change is backward compatible thanks to the good design of `KafkaConfig`.
   
   `RETRIES_CONFIG` is a new config for `GetOffsetShell`, but I don't think we would need a KIP for this change though, It's better to add this as an addendum to KIP-734 since they are related.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org