[GitHub] [flink] rkhachatryan commented on a change in pull request #18931: [FLINK-26396][state/changelog] Fail upload if last attempt times out

[GitBox <gi...@apache.org>]

rkhachatryan commented on a change in pull request #18931:
URL: https://github.com/apache/flink/pull/18931#discussion_r816813229



##########
File path: flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/RetryingExecutor.java
##########
@@ -102,35 +129,48 @@ public void close() throws Exception {
          */
         private final AtomicBoolean attemptCompleted = new AtomicBoolean(false);
 
+        private final AtomicInteger activeAttempts;
+
         private final Histogram attemptsPerTaskHistogram;
 
         RetriableTask(
                 RetriableAction runnable,
                 RetryPolicy retryPolicy,
-                ScheduledExecutorService executorService,
-                Histogram attemptsPerTaskHistogram) {
+                ScheduledExecutorService blockingExecutor,
+                Histogram attemptsPerTaskHistogram,

Review comment:
       Hm.. `attemptsPerTaskHistogram` is already the last argument. Could you clarify what do you mean?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org