You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/08 21:01:39 UTC
[GitHub] [airflow] blcksrx opened a new pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
blcksrx opened a new pull request #17496:
URL: https://github.com/apache/airflow/pull/17496
The `job.result` method already invokes on the `hook.insert_job` method, so basically it's duplicated beside of the referenced issue.
https://github.com/apache/airflow/blob/ef1b1242a8907c1f526bb354945cd5eefa3a85e7/airflow/providers/google/cloud/hooks/bigquery.py#L1639-L1641
In addition, In my opinion, the `insert_job` method should only responsible to inserting a job not verifying the job is completed and wait for it.
---
related: #17493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-910535497
@blcksrx can you please rebase the PR the branch is 231 commits behind main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #17496:
URL: https://github.com/apache/airflow/pull/17496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-910641147
@eladkal Thanks man
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-910535497
@blcksrx can you please rebase - it will probably solve the CI problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-901540606
Following test is failing, can you fix it please @blcksrx
```
FAILED tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryInsertJobOperator::test_execute_reattach
```
https://github.com/apache/airflow/pull/17496/checks?check_run_id=3275336377#step:6:7406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-909499087
@kaxil Thanks for noticing, it was an stupid error on unit-test side, I fixed it but unfortunately CI failed because of some conflict in installing packages that is unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-901540606
Following test is failing, can you fix it please @blcksrx
```
FAILED tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryInsertJobOperator::test_execute_reattach
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-910535497
@blcksrx can you please rebase the PR is 231 commits behind main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-894973305
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on pull request #17496: deduplicate running jobs on BigQueryInsertJobOperator
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #17496:
URL: https://github.com/apache/airflow/pull/17496#issuecomment-909499087
@kaxil Thanks for noticing, it was an stupid error on unit-test side, I fixed it but unfortunately CI failed because of some conflict in installing packages that is unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org