You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/15 18:37:52 UTC

[GitHub] [spark] mn-mikke commented on issue #21215: [SPARK-24148][SQL] Overloading array function to support typed empty arrays

mn-mikke commented on issue #21215: [SPARK-24148][SQL] Overloading array function to support typed empty arrays
URL: https://github.com/apache/spark/pull/21215#issuecomment-483368852
 
 
   @srowen Yep, Map types suffer from the same problem. Users could eventually create a column of empty typed maps with using this function and ```map_from_arrays```, but having separate method would be better.
   
   This feature is definitely just nice to have since users can directly use ```Literal.create```. So I wouldn't mind if you wanted me to close the PR without merging. On the other hand, IMHO users shouldn't be forced to use call methods from ```org.apache.spark.sql.catalyst.expressions```. This doesn't sound like public API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org