[GitHub] httpcomponents-core pull request #90: Define a timeout exception and deadlin...

[garydgregory <gi...@git.apache.org>]

Github user garydgregory commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-core/pull/90#discussion_r225022740
  
    --- Diff: httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
    @@ -94,7 +95,7 @@ public synchronized T get(final long timeout, final TimeUnit unit)
             if (this.completed) {
                 return getResult();
             } else if (waitTime <= 0) {
    -            throw new TimeoutException();
    +            throw TimeoutValueException.ofMillis(msecs, msecs + Math.abs(waitTime));
    --- End diff --
    
    @ok2c I've updated this PR to fix the above issue and also refactored our use of a deadline long and its redundant code into a new Deadline class.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org