You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/08/14 22:00:40 UTC
(superset) branch default_chart_settings updated (4558224935 -> 9a82c2015c)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a change to branch default_chart_settings
in repository https://gitbox.apache.org/repos/asf/superset.git
discard 4558224935 refactor: Consolidate applyDatasetChartDefaults tests into hydrateExplore.test.ts
discard e989a741c3 feat(explore): Add temporal column support and comprehensive test coverage for chart defaults
discard 37363d52c8 .gitirnore
discard 166340cb4e refactor(explore): Extract chart defaults logic into testable function
discard 51b511c547 feat(datasets): Replace chart defaults with Explore controls
discard 85449dac0a fix: Move Chart Defaults outside Fieldset to prevent onChange override
discard 5915d3dfb8 fix: Chart Defaults onChange handlers not being called
discard 05b8cc8721 debug: Add comprehensive logging for Chart Defaults data flow
discard e427e31cf9 refactor: Simplify Chart Defaults extra field parsing
discard 864d338142 fix: DatasetEditor Chart Defaults not displaying saved values
discard 8623e31d2d feat(dataset): Add chart creation defaults to improve UX
add e2a9f2dead chore: Increase memory limit on webpack ts checker plugin (#34653)
add 698de7a38d feat(dashboard): change chart background option from "White" to "Solid" (#34655)
add e452f5b70d fix(install): set SUPERSET_VERSION_RC at the right time (#21083)
add 1947d4da76 fix(daos/tag): prevent non-unique tags getting created along with unique ones (#32405)
add 2465ab4a98 chore: add more csv tests (#32663)
add f50cbd7958 feat: add @sadpandajoe to migrations CODEOWNERS (#34663)
add 5309edf3a5 feat: Implement UI-based system theme administration (#34560)
add baec438be9 feat(filter_state): Added @api and @has_access_api to all methods of filter_state API. (#27086)
add 89f09ea57c fix(open-api): Add missing FormatQueryPayloadSchema and DashboardScreenshotPostSchema to open-api component schemas (#33202)
add ab13166e41 fix: activity table delta time (#33503)
add 6d827cf905 fix(security): grant TableSchemaView to only sql_lab role (#32340)
add e88096f75c fix(presto): return proper data type for column (#34304)
add 34e10f5972 fix(superset-ui-core): Include appRoot in endpoint of SupersetClientClass.postForm action (#34395)
add b25722ee2b fix(sqllab): show actual execution duration in Query History (#34511)
add cb899f691b fix(csv_tests): Import from utils (#34664)
add f3884a2db8 fix(theming): Theming visual fixes p5 (#34585)
add 1a57e50bd6 refactor: Migrate ExploreChartPanel to typescript (#34606)
add 58ebc57285 feat(sqllab): improve SaveDatasetModal design with proper theme spacing (#34658)
add ecfb9f7d7c fix(row_level_security): Correct api response code for update (#34672)
add bce476c4a2 feat(extension): Add extension for chart header (#34678)
add d79fc92a1a fix(theming): Fix ag-grid theming regression in SQL Lab (#34675)
add 1101182654 fix(bootstrapData): Missing application_root data throws an error (#34680)
add f6353bd1e8 fix: Bar chart crash when switching from Big Number (#34671)
add 47874318df fix: Invalid error tooltip if control label is function (#34698)
add 2403d8d584 docs: CVEs added to 5.0.0 and 4.1.3 documentation (#34701)
add 03ba5b6949 feat(dataset): Add chart creation defaults to improve UX
add 1d3c186fec fix: DatasetEditor Chart Defaults not displaying saved values
add 46924ad89e refactor: Simplify Chart Defaults extra field parsing
add 51b887901f debug: Add comprehensive logging for Chart Defaults data flow
add 8bdb41674c fix: Chart Defaults onChange handlers not being called
add 377bccd464 fix: Move Chart Defaults outside Fieldset to prevent onChange override
add 6e735d40a8 feat(datasets): Replace chart defaults with Explore controls
add 031938edb8 refactor(explore): Extract chart defaults logic into testable function
add cb993639ce feat(explore): Add temporal column support and comprehensive test coverage for chart defaults
add 489d8a4b83 refactor: Consolidate applyDatasetChartDefaults tests into hydrateExplore.test.ts
add 9a82c2015c trying further
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4558224935)
\
N -- N -- N refs/heads/default_chart_settings (9a82c2015c)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.github/CODEOWNERS | 2 +-
.gitignore | 2 +-
RELEASING/make_tarball.sh | 3 +-
RESOURCES/STANDARD_ROLES.md | 6 +-
docs/docs/configuration/theming.mdx | 82 +++--
docs/docs/security/cves.mdx | 14 +
.../cypress-base/cypress/e2e/auth/login.test.ts | 2 +-
superset-frontend/package-lock.json | 6 +-
superset-frontend/package.json | 2 -
.../packages/superset-ui-core/package.json | 2 +
.../src/components/Button/index.tsx | 11 +-
.../{index.tsx => DropdownContainer.tsx} | 6 -
.../src/components/DropdownContainer/index.tsx | 384 +--------------------
.../ThemedAgGridReact/ThemedAgGridReact.test.tsx | 220 ++++++++++++
.../src/components/ThemedAgGridReact/index.tsx | 190 ++++++++++
.../ThemedAgGridReact}/setupAGGridModules.ts | 4 +
.../superset-ui-core/src/components/index.ts | 5 +
.../src/connection/SupersetClientClass.ts | 10 +-
.../src/query/types/QueryFormData.ts | 2 +
.../packages/superset-ui-core/src/theme/types.ts | 7 +-
.../superset-ui-core/src/theme/utils/themeUtils.ts | 10 +
.../src/time-comparison/fetchTimeRange.ts | 8 +-
.../superset-ui-core/src/ui-overrides/types.ts | 23 +-
.../test/connection/SupersetClientClass.test.ts | 40 ++-
.../plugin-chart-ag-grid-table/package.json | 2 -
.../src/AgGridTable/index.tsx | 15 +-
.../src/AgGridTableChart.tsx | 5 +-
.../src/renderers/NumericCellRenderer.tsx | 2 +-
.../src/styles/index.tsx | 11 +-
.../plugin-chart-ag-grid-table/src/types.ts | 8 +-
.../src/utils/filterValueGetter.ts | 2 +-
.../src/utils/formatValue.ts | 5 +-
.../src/utils/getCellClass.ts | 2 +-
.../src/utils/getCellStyle.ts | 2 +-
.../src/utils/getInitialSortState.ts | 5 +-
.../src/utils/useColDefs.ts | 2 +-
.../src/utils/useTableTheme.ts | 2 +-
.../src/Timeseries/Regular/Bar/controlPanel.tsx | 7 +-
.../SqlLab/components/ResultSet/ResultSet.test.tsx | 2 +-
.../SaveDatasetModal/SaveDatasetModal.test.tsx | 2 +-
.../SqlLab/components/SaveDatasetModal/index.tsx | 96 ++++--
.../SqlLab/components/SaveQuery/SaveQuery.test.tsx | 2 +-
superset-frontend/src/components/Chart/Chart.tsx | 37 +-
.../components/Chart/ChartErrorMessage.test.tsx | 2 +-
.../src/components/Chart/ChartErrorMessage.tsx | 2 +-
.../Datasource/DatasourceEditor.test.jsx | 3 +-
.../FilterableTable/FilterableTable.test.tsx | 2 +-
.../src/components/GridTable/GridTable.test.tsx | 2 +-
.../src/components/GridTable/index.tsx | 129 +++----
superset-frontend/src/constants.ts | 1 -
.../components/menu/BackgroundStyleDropdown.tsx | 4 +-
.../src/dashboard/util/backgroundStyleOptions.ts | 2 +-
.../src/explore/components/ChartPills.tsx | 15 +-
.../explore/components/ControlPanelsContainer.tsx | 1 +
.../components/DataTablesPane/DataTablesPane.tsx | 6 +-
.../components/ResultsPaneOnDashboard.tsx | 4 +-
.../DataTablesPane/components/SamplesPane.tsx | 6 +-
.../DataTablesPane/components/useResultsPane.tsx | 10 +-
.../test/ResultsPaneOnDashboard.test.tsx | 5 +-
.../DataTablesPane/test/SamplesPane.test.tsx | 9 +-
.../components/DataTablesPane/test/fixture.tsx | 14 +-
.../src/explore/components/DataTablesPane/types.ts | 28 +-
.../src/explore/components/ExploreAlert.tsx | 2 +-
.../ExploreChartPanel/{index.jsx => index.tsx} | 143 +++++---
.../useResizeDetectorByObserver.ts | 2 +-
.../ExploreViewContainer.test.tsx | 167 +++++++++
.../components/ExploreViewContainer/index.jsx | 6 +-
superset-frontend/src/explore/types.ts | 3 +-
.../src/features/home/ActivityTable.tsx | 3 +
superset-frontend/src/features/home/RightMenu.tsx | 2 +-
superset-frontend/src/features/themes/api.test.ts | 122 +++++++
.../themes/api.ts} | 26 +-
.../src/features/themes/types.test.ts | 167 +++++++++
superset-frontend/src/features/themes/types.ts | 2 +
superset-frontend/src/hooks/apiResources/charts.ts | 2 +-
.../src/pages/AnnotationList/index.tsx | 14 +-
superset-frontend/src/pages/GroupsList/index.tsx | 10 +-
.../src/pages/QueryHistoryList/index.tsx | 15 +-
superset-frontend/src/pages/RolesList/index.tsx | 10 +-
.../src/pages/ThemeList/index.test.tsx | 287 +++++++++++++++
superset-frontend/src/pages/ThemeList/index.tsx | 175 +++++++++-
superset-frontend/src/pages/UsersList/index.tsx | 10 +-
superset-frontend/src/theme/ThemeController.ts | 114 ++----
.../src/theme/tests/ThemeController.test.ts | 347 +++----------------
superset-frontend/src/types/bootstrapTypes.ts | 9 +-
.../src/utils/getBootstrapData.test.ts | 27 ++
superset-frontend/src/utils/getBootstrapData.ts | 17 +-
superset-frontend/src/views/App.tsx | 2 +-
superset-frontend/src/views/CRUD/types.ts | 2 +
.../src/views/theme.bootstrap.test.ts | 132 +++++++
superset-frontend/webpack.config.js | 17 +-
superset/commands/theme/delete.py | 4 +
superset/commands/theme/exceptions.py | 8 +
superset/commands/theme/set_system_theme.py | 126 +++++++
superset/config.py | 16 +-
superset/daos/tag.py | 3 -
superset/daos/theme.py | 56 +++
superset/dashboards/api.py | 2 +
superset/dashboards/filter_state/api.py | 6 +
superset/db_engine_specs/presto.py | 6 +-
...233f5365c9e_is_system_default_is_system_dark.py | 87 +++++
superset/models/core.py | 7 +
superset/queries/api.py | 1 +
superset/row_level_security/api.py | 2 +-
superset/security/manager.py | 4 +-
superset/sqllab/api.py | 1 +
superset/themes/api.py | 263 +++++++++++++-
superset/themes/types.py | 16 -
superset/themes/utils.py | 28 +-
superset/views/base.py | 68 ++--
.../security/row_level_security_tests.py | 2 +-
tests/integration_tests/security_tests.py | 3 +
tests/integration_tests/tags/dao_tests.py | 9 +
tests/integration_tests/themes/api_tests.py | 7 +-
.../themes/test_theme_api_permissions.py | 260 ++++++++++++++
tests/unit_tests/charts/test_client_processing.py | 91 +++++
.../commands/theme/test_set_system_theme.py | 231 +++++++++++++
tests/unit_tests/daos/test_theme_dao.py | 233 +++++++++++++
tests/unit_tests/themes/api_test.py | 8 +-
tests/unit_tests/themes/test_utils.py | 18 +-
tests/unit_tests/utils/csv_tests.py | 174 +++++++++-
121 files changed, 3763 insertions(+), 1307 deletions(-)
copy superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/{index.tsx => DropdownContainer.tsx} (99%)
create mode 100644 superset-frontend/packages/superset-ui-core/src/components/ThemedAgGridReact/ThemedAgGridReact.test.tsx
create mode 100644 superset-frontend/packages/superset-ui-core/src/components/ThemedAgGridReact/index.tsx
rename superset-frontend/{src/setup => packages/superset-ui-core/src/components/ThemedAgGridReact}/setupAGGridModules.ts (91%)
rename superset-frontend/src/explore/components/ExploreChartPanel/{index.jsx => index.tsx} (78%)
create mode 100644 superset-frontend/src/features/themes/api.test.ts
copy superset-frontend/src/{utils/cachedSupersetGet.ts => features/themes/api.ts} (61%)
create mode 100644 superset-frontend/src/features/themes/types.test.ts
create mode 100644 superset-frontend/src/pages/ThemeList/index.test.tsx
create mode 100644 superset-frontend/src/views/theme.bootstrap.test.ts
create mode 100644 superset/commands/theme/set_system_theme.py
create mode 100644 superset/migrations/versions/2025-08-05_14-38_c233f5365c9e_is_system_default_is_system_dark.py
create mode 100644 tests/integration_tests/themes/test_theme_api_permissions.py
create mode 100644 tests/unit_tests/commands/theme/test_set_system_theme.py
create mode 100644 tests/unit_tests/daos/test_theme_dao.py