You are viewing a plain text version of this content. The canonical link for it is here.
Posted to surefire-commits@maven.apache.org by br...@apache.org on 2006/03/04 04:12:34 UTC

svn commit: r383008 - /maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java

Author: brett
Date: Fri Mar  3 19:12:32 2006
New Revision: 383008

URL: http://svn.apache.org/viewcvs?rev=383008&view=rev
Log:
[MSUREFIRE-23] fix group execution

Modified:
    maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java

Modified: maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java
URL: http://svn.apache.org/viewcvs/maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java?rev=383008&r1=383007&r2=383008&view=diff
==============================================================================
--- maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java (original)
+++ maven/surefire/branches/surefire-testng/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGDirectoryTestSuite.java Fri Mar  3 19:12:32 2006
@@ -32,6 +32,7 @@
 
 import java.io.File;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.Map;
@@ -119,6 +120,14 @@
             XmlTest xmlTest = new XmlTest( suite );
             xmlTest.setName( testSet.getName() );
             xmlTest.setXmlClasses( Collections.singletonList( new XmlClass( testSet.getTestClass() ) ) );
+            if ( groups != null )
+            {
+                xmlTest.setIncludedGroups( Arrays.asList( groups.split( "," ) ) );
+            }
+            if ( excludedGroups != null )
+            {
+                xmlTest.setExcludedGroups( Arrays.asList( excludedGroups.split( "," ) ) );
+            }
 
             if ( !TestNGClassFinder.isTestNGClass( testSet.getTestClass(), annotationFinder ) )
             {
@@ -131,14 +140,6 @@
         testNG.setVerbose( 0 );
 
         // TODO: check these work, otherwise put them in the xmlTest instances
-        if ( groups != null )
-        {
-            testNG.setGroups( groups );
-        }
-        if ( excludedGroups != null )
-        {
-            testNG.setExcludedGroups( excludedGroups );
-        }
         testNG.setXmlSuites( Collections.singletonList( suite ) );
 
         testNG.setListenerClasses( new ArrayList() );