You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/05/13 15:32:20 UTC

[GitHub] spark pull request #20800: [SPARK-23627][SQL] Provide isEmpty in Dataset

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20800#discussion_r187804796
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -511,6 +511,14 @@ class Dataset[T] private[sql](
        */
       def isLocal: Boolean = logicalPlan.isInstanceOf[LocalRelation]
     
    +  /**
    +   * Returns true if the `Dataset` is empty.
    +   *
    +   * @group basic
    +   * @since 2.4.0
    +   */
    +  def isEmpty: Boolean = rdd.isEmpty()
    --- End diff --
    
    @goungoun maybe; it depends on the Dataset. I'd follow @maropu 's lead or close this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org